Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E359D9661 for ; Mon, 17 Oct 2011 22:43:35 +0000 (UTC) Received: (qmail 18337 invoked by uid 500); 17 Oct 2011 22:43:35 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 18303 invoked by uid 500); 17 Oct 2011 22:43:35 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 18136 invoked by uid 99); 17 Oct 2011 22:43:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Oct 2011 22:43:35 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Oct 2011 22:43:33 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 3085430DBB9 for ; Mon, 17 Oct 2011 22:43:12 +0000 (UTC) Date: Mon, 17 Oct 2011 22:43:12 +0000 (UTC) From: "jiraposter@reviews.apache.org (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <149810989.2802.1318891392200.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <783315702.2614.1318889950591.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129297#comment-13129297 ] jiraposter@reviews.apache.org commented on HBASE-4607: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2411/ ----------------------------------------------------------- Review request for hbase and Prakash Khemani. Summary ------- This is an attempt to fix the fact that SplitLogWorker threads are not being terminated properly in some unit tests. This probably does not happen in production because the master always creates the log-splitting ZK node, but it does happen in 89-fb. Thanks to Prakash Khemani for help on this. This addresses bug hbase-4607. https://issues.apache.org/jira/browse/hbase-4607 Diffs ----- src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java a43e0b3 Diff: https://reviews.apache.org/r/2411/diff Testing ------- I will run unit tests and post an update when they have passed. Thanks, Mikhail > Split log worker should terminate properly when waiting for znode > ----------------------------------------------------------------- > > Key: HBASE-4607 > URL: https://issues.apache.org/jira/browse/HBASE-4607 > Project: HBase > Issue Type: Bug > Reporter: Mikhail Bautin > Assignee: Mikhail Bautin > Priority: Minor > > This is an attempt to fix the fact that SplitLogWorker threads are not being terminated properly in some unit tests. This probably does not happen in production because the master always creates the log-splitting ZK node, but it does happen in 89-fb. Thanks to Prakash Khemani for help on this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira