Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 12 Oct 2011 18:25:12 +0000 (UTC)
From: "stack (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1377439648.5925.1318443912076.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1909632531.12403.1318142789755.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler
 and TestOpenRegionHandler.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126017#comment-13126017 ] 

stack commented on HBASE-4558:
------------------------------

In testOpenedRegionHandlerOnMasterRestart, after you start the cluster, do you open a try so you can catch any exceptions and for sure shutdown the cluster in a finally block?  If not, add on commit.

+1 on commit.  Thanks for making this fix Ram.
                
> Refactor TestOpenedRegionHandler and TestOpenRegionHandler.
> -----------------------------------------------------------
>
>                 Key: HBASE-4558
>                 URL: https://issues.apache.org/jira/browse/HBASE-4558
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4558_1.patch, HBASE-4558_2.patch
>
>
> This is an improvement task taken up to refactor TestOpenedRegionandler and TestOpenRegionHandler so that MockServer and MockRegionServerServices can be accessed from a common utility package.
> If we do this then one of the testcases in TestOpenedRegionHandler need not start up a cluster and also moving it into a common package will help in mocking the server for future testcases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira