Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E0647838 for ; Sun, 16 Oct 2011 02:26:34 +0000 (UTC) Received: (qmail 16490 invoked by uid 500); 16 Oct 2011 02:26:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 16458 invoked by uid 500); 16 Oct 2011 02:26:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 16450 invoked by uid 99); 16 Oct 2011 02:26:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Oct 2011 02:26:34 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Oct 2011 02:26:33 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id CCD6A30AEEF for ; Sun, 16 Oct 2011 02:26:11 +0000 (UTC) Date: Sun, 16 Oct 2011 02:26:11 +0000 (UTC) From: "Ted Yu (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <1190391263.17947.1318731971840.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2109502295.13523.1318216470010.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128327#comment-13128327 ] Ted Yu commented on HBASE-4563: ------------------------------- Thanks for the detailed test report. +1 on patches. There is some formatting: {code} + } finally { + this.journal.add(JournalEntry.CLOSED_PARENT_REGION); + } {code} The right curly brace before finally should be moved left by 3 spaces. Same with the closing right curly brace. See HBASE-3678 for Formatter for Eclipse. > When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read > --------------------------------------------------------------------------------------------------------- > > Key: HBASE-4563 > URL: https://issues.apache.org/jira/browse/HBASE-4563 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.90.4, 0.92.0 > Reporter: bluedavy > Priority: Blocker > Fix For: 0.90.5 > > Attachments: HBASE-4563-0.90.patch, HBASE-4563-0.92.patch, HBASE-4563-trunk.patch, test-4563-0.90.txt, test-4563-0.92.txt, test-4563-trunk.txt > > > Follow below steps to replay the problem: > 1. change the SplitTransaction.java as below,just like mock the hdfs error. > {code:title=SplitTransaction.java|borderStyle=solid} > List hstoreFilesToSplit = this.parent.close(false); > throw new IOException("some unexpected error in close store files"); > {code} > 2. update the regionserver code,restart; > 3. create a table & put some data to the table; > 4. split the table; > 5. scan the table,then it'll fail. > We can fix the bug just use the patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira