Return-Path: 
 <issues-return-23654-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A02399147
	for <apmail-hbase-issues-archive@www.apache.org>;
 Mon, 31 Oct 2011 23:55:56 +0000 (UTC)
Received: (qmail 91617 invoked by uid 500); 31 Oct 2011 23:55:56 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 91514 invoked by uid 500); 31 Oct 2011 23:55:56 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 91505 invoked by uid 99); 31 Oct 2011 23:55:56 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2011 23:55:56 +0000
X-ASF-Spam-Status: No, hits=-2001.2 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2011 23:55:54 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 1452D32B06D
	for <issues@hbase.apache.org>; Mon, 31 Oct 2011 23:55:33 +0000 (UTC)
Date: Mon, 31 Oct 2011 23:55:33 +0000 (UTC)
From: "Phabricator (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1089523115.43328.1320105333085.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2082554276.34175.1319840432385.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
 all the key values for a specific row.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140699#comment-13140699 ] 

Phabricator commented on HBASE-4698:
------------------------------------

Liyin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".

  Thanks Mikhail's and Nicolas's review and response the comments inline.
  I will update the diff to address the comments.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:70 I used the Eclipse code formatter to format the code here, which is based on the hbase code style mentioned in HBase book.
  http://hbase.apache.org/book.html#eclipse

  However, there is no rule saying I have to add an empty line here.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:251 Good point:) thanks a lot. I will update this.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:253 I don't understand why this line is NOT necessary.
  This function DOES throw out IOException, doesn't it?
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:247 Why I need to remove this line?
  According to the code format from the HBase book, there is no need to remove empty line in the java doc:

  HBase book:
  http://hbase.apache.org/book.html#eclipse

  The setting:
  <setting id="org.eclipse.jdt.core.formatter.comment.clear_blank_lines_in_javadoc_comment" value="false"/>


REVISION DETAIL
  https://reviews.facebook.net/D111

                
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
>                 Key: HBASE-4698
>                 URL: https://issues.apache.org/jira/browse/HBASE-4698
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch
>
>
> When using HFile Pretty Printer to debug HBase issues, 
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira