hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liyin (Liyin Tang)" <phabrica...@reviews.facebook.net>
Subject [Differential] [Accepted] D87: [jira] [HBASE-4686] [89-fb] Fix per-store metrics aggregation
Date Thu, 27 Oct 2011 23:56:49 GMT
Liyin has accepted the revision "[jira] [HBASE-4686] [89-fb] Fix per-store metrics aggregation
".

  It looks good to me. Just one minor comments:

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:384 This api
looks like very hard to use.
  Maybe we can elaborate what's in the map a little bit:)

REVISION DETAIL
  https://reviews.facebook.net/D87

Mime
View raw message