hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liyin (Liyin Tang)" <phabrica...@reviews.facebook.net>
Subject [Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.
Date Sat, 29 Oct 2011 01:02:55 GMT
Liyin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print
all the key values for a specific row.".

  Thanks Mikhail for reviewing. Response the comments inline.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:137 I agree we can
print an error message here and terminate the printing if the user sets an incomplete option.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:256-257 Actually,
no:)
  If we don't want to seek to a specific row, then the param row here will be set null
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:239 The row is the
specific row user wants to print. It is not the key portion of the key value:)

  The scanner always seeks to first key value for that row and here it only compares the row
portion of the key.

  I shall add a java doc here to clarify it better:)



REVISION DETAIL
  https://reviews.facebook.net/D111

Mime
View raw message