hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mbautin (Mikhail Bautin)" <phabrica...@reviews.facebook.net>
Subject [Differential] [Accepted] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.
Date Mon, 31 Oct 2011 17:44:25 GMT
mbautin has accepted the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all
the key values for a specific row.".

  Looks good (a few very minor comments inline).

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71 Nit: it would
be nice to use Javadoc-style comments when referring to a specific field.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:133 Coding style:
space between key and !=
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:136-137 Nit: "the
kv" seems to imply there is only one kv for the row, which is most often not the case

REVISION DETAIL
  https://reviews.facebook.net/D111

Mime
View raw message