hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4687) regionserver may miss zk-heartbeats to master when replaying edits at region open
Date Thu, 27 Oct 2011 19:46:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137443#comment-13137443
] 

jiraposter@reviews.apache.org commented on HBASE-4687:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2585/#review2889
-----------------------------------------------------------


Looks good to me.

Could you explain what the ramifications of not doing this are? I.e. what does the progress
reporter have to do with ZK heartbeats?
Thanks!

- Lars


On 2011-10-27 19:32:54, Prakash Khemani wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2585/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-27 19:32:54)
bq.  
bq.  
bq.  Review request for hbase, Dhruba Borthakur, Jonathan Gray, and Nicolas Spiegelberg.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  must report.progress() at least once per edits file when replaying edits
bq.  
bq.  
bq.  This addresses bug HBASE-4687.
bq.      https://issues.apache.org/jira/browse/HBASE-4687
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 5243b58 
bq.  
bq.  Diff: https://reviews.apache.org/r/2585/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  small change and not tested.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Prakash
bq.  
bq.


                
> regionserver may miss zk-heartbeats to master when replaying edits at region open
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-4687
>                 URL: https://issues.apache.org/jira/browse/HBASE-4687
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>
> replayRecoveredEdits() should do another reporter.progress() before returning.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message