hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4568) Make zk dump jsp response more quickly
Date Thu, 13 Oct 2011 22:42:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127067#comment-13127067
] 

jiraposter@reviews.apache.org commented on HBASE-4568:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2385/#review2574
-----------------------------------------------------------


+1. Changes look good Liyin.

- Kannan


On 2011-10-13 22:36:46, Liyin wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2385/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-13 22:36:46)
bq.  
bq.  
bq.  Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin,
Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik
Ranganathan, and Nicolas Spiegelberg.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  1) For each zk dump, currently hbase will create a zk client instance every time. 
bq.  This is quite slow when any machines in the quorum is dead. Because it will connect to
each machine in the zk quorum again.
bq.  
bq.  <code>
bq.  HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
bq.  Configuration conf = master.getConfiguration();
bq.  HBaseAdmin hbadmin = new HBaseAdmin(conf);
bq.  HConnection connection = hbadmin.getConnection();
bq.  ZooKeeperWatcher watcher = connection.getZooKeeperWatcher();
bq.  </code>
bq.  
bq.  So we can simplify this:
bq.  <code>
bq.  HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
bq.  ZooKeeperWatcher watcher = master.getZooKeeperWatcher();
bq.  </code>
bq.  
bq.  2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded
the default time out as 1 min. 
bq.  It would be nice to make this configurable and set it to a low time out.
bq.  
bq.  When hbase tries to connect to each machine in the zk quorum, it will create the socket,
and then set the socket time out, and read it with this time out.
bq.  It means hbase will create a socket and connect to the zk server with 0 time out at first,
which will take a long time. 
bq.  Because a timeout of zero is interpreted as an infinite timeout. The connection will
then block until established or an error occurs.
bq.  
bq.  3) The recoverable zookeeper should be real exponentially backoff when there is connection
loss exception, which will give hbase much longer time window to recover from zk machine failures.
bq.  
bq.  
bq.  This addresses bug HBASE-4568.
bq.      https://issues.apache.org/jira/browse/HBASE-4568
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552 
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java b8c4f61 
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5 
bq.    src/main/resources/hbase-webapps/master/zk.jsp b31d94c 
bq.  
bq.  Diff: https://reviews.apache.org/r/2385/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Running all the unit tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Liyin
bq.  
bq.


                
> Make zk dump jsp response more quickly
> --------------------------------------
>
>                 Key: HBASE-4568
>                 URL: https://issues.apache.org/jira/browse/HBASE-4568
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>
> For each zk dump, currently hbase will create a zk client instance every time. 
> This is quite slow when any machines in the quorum is dead. Because it will connect to
each machine in the zk quorum again.
>   HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
>   Configuration conf = master.getConfiguration();
>   HBaseAdmin hbadmin = new HBaseAdmin(conf);
>   HConnection connection = hbadmin.getConnection();
>   ZooKeeperWatcher watcher = connection.getZooKeeperWatcher();
> So we can simplify this:
>   HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
>   ZooKeeperWatcher watcher = master.getZooKeeperWatcher();
> Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded
the default time out as 1 min. 
> It would be nice to make this configurable and set it to a low time out.
> When hbase tries to connect to each machine in the zk quorum, it will create the socket,
and then set the socket time out, and read it with this time out.
> It means hbase will create a socket and connect to the zk server with 0 time out at first,
which will take a long time. 
> Because a timeout of zero is interpreted as an infinite timeout. The connection will
then block until established or an error occurs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message