hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4422) Move block cache parameters and references into single CacheConf class
Date Mon, 10 Oct 2011 21:08:31 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124474#comment-13124474
] 

jiraposter@reviews.apache.org commented on HBASE-4422:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2089/
-----------------------------------------------------------

(Updated 2011-10-10 21:08:15.751510)


Review request for hbase, Dhruba Borthakur, Michael Stack, and Li Pi.


Changes
-------

Fix to TestCacheOnWrite (not sure how this got through to now?)


Summary
-------

Creates a new CacheConfig class and moves almost everything block cache related into this
single class.  Adding new configuration params and booleans and such should be much better.

All tests are NOT passing yet, still working on it, but wanted to have something up today.
 Basically "code complete" but broken :)


This addresses bug HBASE-4422.
    https://issues.apache.org/jira/browse/HBASE-4422


Diffs (updated)
-----

  /src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV1.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/util/BloomFilterFactory.java 1179008 
  /src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/RandomSeek.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFilePerformance.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileReaderV1.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestReseekTo.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java 1179008

  /src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/regionserver/TestCompoundBloomFilter.java 1179008

  /src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java
1179008 
  /src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java 1179008 
  /src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java 1179008 

Diff: https://reviews.apache.org/r/2089/diff


Testing
-------

Still working through some tests that aren't passing.


Thanks,

Jonathan


                
> Move block cache parameters and references into single CacheConf class
> ----------------------------------------------------------------------
>
>                 Key: HBASE-4422
>                 URL: https://issues.apache.org/jira/browse/HBASE-4422
>             Project: HBase
>          Issue Type: Improvement
>          Components: io
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.92.0
>
>         Attachments: CacheConfig92-v8.patch
>
>
> From StoreFile down to HFile, we currently use a boolean argument for each of the various
block cache configuration parameters that exist.  The number of parameters is going to continue
to increase as we look at compressed cache, delta encoding, and more specific L1/L2 configuration.
 Every new config currently requires changing many constructors because it introduces a new
boolean.
> We should move everything into a single class so that modifications are much less disruptive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message