hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4520) Better handling of Bloom filter type discrepancy between HFile and CF config
Date Sun, 02 Oct 2011 15:08:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119020#comment-13119020
] 

jiraposter@reviews.apache.org commented on HBASE-4520:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2143/#review2252
-----------------------------------------------------------

Ship it!


- Ted


On 2011-10-02 08:05:42, Mikhail Bautin wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2143/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-02 08:05:42)
bq.  
bq.  
bq.  Review request for hbase, Michael Stack and Jonathan Gray.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Modify StoreFile to make it clear where Bloom filter type settings come from. We have
two sources of truth: (1) HFile; and (2) CF configuration. (1) takes precedence in the reader,
and (2) takes precedence in the writer.
bq.  
bq.  
bq.  This addresses bug HBASE-4520.
bq.      https://issues.apache.org/jira/browse/HBASE-4520
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fa629c7 
bq.  
bq.  Diff: https://reviews.apache.org/r/2143/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Running unit tests. I will post the results here -- please don't commit this yet.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Mikhail
bq.  
bq.


                
> Better handling of Bloom filter type discrepancy between HFile and CF config
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-4520
>                 URL: https://issues.apache.org/jira/browse/HBASE-4520
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>            Priority: Minor
>             Fix For: 0.94.0
>
>
> Modify StoreFile to make it clear where Bloom filter type settings come from. We have
two sources of truth: (1) HFile; and (2) CF configuration. (1) takes precedence in the reader,
and (2) takes precedence in the writer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message