hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4422) Move block cache parameters and references into single CacheConf class
Date Wed, 12 Oct 2011 04:49:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125588#comment-13125588
] 

jiraposter@reviews.apache.org commented on HBASE-4422:
------------------------------------------------------



bq.  On 2011-10-12 02:24:55, Mikhail Bautin wrote:
bq.  > 1032 unit tests passed, 0 failed, 16 skipped (I still don't know why Maven skips
tests and whether it is a problem -- any idea?)
bq.  > I think this patch is good to go.

Mikhail: My guess are these are the tests that have an '@Ignore' annotation preceding the
'@Test' annotation.. though if I do the below:

$ grep -r '@Ignore' src/test/|grep -v svn|grep -v BROKE |wc

I get 23... maybe its something else?


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2089/#review2526
-----------------------------------------------------------


On 2011-10-11 22:18:32, Jonathan Gray wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2089/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-11 22:18:32)
bq.  
bq.  
bq.  Review request for hbase, Dhruba Borthakur, Michael Stack, and Li Pi.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Creates a new CacheConfig class and moves almost everything block cache related into
this single class.  Adding new configuration params and booleans and such should be much better.
bq.  
bq.  All tests are NOT passing yet, still working on it, but wanted to have something up today.
 Basically "code complete" but broken :)
bq.  
bq.  
bq.  This addresses bug HBASE-4422.
bq.      https://issues.apache.org/jira/browse/HBASE-4422
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java PRE-CREATION 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV1.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java 1182021

bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/util/BloomFilterFactory.java 1182021 
bq.    /src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/RandomSeek.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFilePerformance.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileReaderV1.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestReseekTo.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java 1182021

bq.    /src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java 1182021

bq.    /src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java 1182021

bq.    /src/test/java/org/apache/hadoop/hbase/regionserver/TestCompoundBloomFilter.java 1182021

bq.    /src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java 1182021

bq.    /src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java 1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java
1182021 
bq.    /src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java 1182021

bq.  
bq.  Diff: https://reviews.apache.org/r/2089/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Still working through some tests that aren't passing.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jonathan
bq.  
bq.


                
> Move block cache parameters and references into single CacheConf class
> ----------------------------------------------------------------------
>
>                 Key: HBASE-4422
>                 URL: https://issues.apache.org/jira/browse/HBASE-4422
>             Project: HBase
>          Issue Type: Improvement
>          Components: io
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.92.0
>
>         Attachments: CacheConfig92-v8.patch, HBASE-4422-FINAL-branch92.patch, HBASE-4422-FINAL-trunk.patch
>
>
> From StoreFile down to HFile, we currently use a boolean argument for each of the various
block cache configuration parameters that exist.  The number of parameters is going to continue
to increase as we look at compressed cache, delta encoding, and more specific L1/L2 configuration.
 Every new config currently requires changing many constructors because it introduces a new
boolean.
> We should move everything into a single class so that modifications are much less disruptive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message