hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-2856) TestAcidGuarantee broken on trunk
Date Wed, 05 Oct 2011 23:54:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121609#comment-13121609
] 

jiraposter@reviews.apache.org commented on HBASE-2856:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2224/#review2376
-----------------------------------------------------------


Rest of the diff reviewed, and comments inline. (Joint review with Kannan).


/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
<https://reviews.apache.org/r/2224/#comment5472>

    Rename to: hasMemstoreTS



/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
<https://reviews.apache.org/r/2224/#comment5469>

    if () {
    }



/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
<https://reviews.apache.org/r/2224/#comment5470>

    Remove comment



/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
<https://reviews.apache.org/r/2224/#comment5471>

    Should check against the constant:
    Bytes.toInt(keyValueFormatVersion) == KEY_VALUE_VER_WITH_MEMSTORE



/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
<https://reviews.apache.org/r/2224/#comment5467>

    if () {
    }
    
    1. Discussed with Amitanand, he is planning to move this to the end of the KV (to play
nice with delta encoding). 
    2. Also planning to store this in varying-length format
    3. Also, if (kv.memstoreTS < current read point across all scanners) then we can just
write a 0. This would be the case for most of the KV's except the last few written. 



/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
<https://reviews.apache.org/r/2224/#comment5468>

    Need a:
    if (this.includeMemstoreTS) {
    }


- Karthik


On 2011-10-05 19:18:51, Amitanand Aiyer wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2224/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-05 19:18:51)
bq.  
bq.  
bq.  Review request for Ted Yu, Michael Stack, Kannan Muthukkaruppan, and Karthik Ranganathan.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  address the 2856 issues by writing the memstoreTS to the disk.
bq.  
bq.  version v11 of the patch.
bq.  
bq.  uploading it here for easier review process.
bq.  
bq.  
bq.  This addresses bug HBASE-2856.
bq.      https://issues.apache.org/jira/browse/HBASE-2856
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java 1174515 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java 1174515 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java 1174515 
bq.    /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java 1175027 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1174515 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/ReadWriteConsistencyControl.java
1174515 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java 1174515 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1174515 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 1174515 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 1174515 
bq.    /src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java 1175027 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java 1174515 
bq.    /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java 1174515 
bq.    /src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java 1174515 
bq.  
bq.  Diff: https://reviews.apache.org/r/2224/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  mvn test
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Amitanand
bq.  
bq.


                
> TestAcidGuarantee broken on trunk 
> ----------------------------------
>
>                 Key: HBASE-2856
>                 URL: https://issues.apache.org/jira/browse/HBASE-2856
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.89.20100621
>            Reporter: ryan rawson
>            Assignee: Amitanand Aiyer
>            Priority: Blocker
>             Fix For: 0.94.0
>
>         Attachments: 2856-v2.txt, 2856-v3.txt, 2856-v4.txt, 2856-v5.txt, acid.txt
>
>
> TestAcidGuarantee has a test whereby it attempts to read a number of columns from a row,
and every so often the first column of N is different, when it should be the same.  This is
a bug deep inside the scanner whereby the first peek() of a row is done at time T then the
rest of the read is done at T+1 after a flush, thus the memstoreTS data is lost, and previously
'uncommitted' data becomes committed and flushed to disk.
> One possible solution is to introduce the memstoreTS (or similarly equivalent value)
to the HFile thus allowing us to preserve read consistency past flushes.  Another solution
involves fixing the scanners so that peek() is not destructive (and thus might return different
things at different times alas).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message