hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nspiegelberg (Nicolas Spiegelberg)" <phabrica...@reviews.facebook.net>
Subject [Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.
Date Mon, 31 Oct 2011 17:51:31 GMT
nspiegelberg has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer
print all the key values for a specific row.".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:136-137 I would remove
this line.  We should only print out information we inferred from user input versus this is
direct input.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:266-267 remove these
2 println() as well

REVISION DETAIL
  https://reviews.facebook.net/D111

Mime
View raw message