hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4377) [hbck] Offline rebuild .META. from fs data only.
Date Mon, 31 Oct 2011 21:05:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140554#comment-13140554
] 

jiraposter@reviews.apache.org commented on HBASE-4377:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2287/
-----------------------------------------------------------

(Updated 2011-10-31 21:03:52.791775)


Review request for hbase and Ted Yu.


Changes
-------

Updated to address stacks comments.  I believe Seb's patch wasn't necessary in 0.90 since
that code came in on HBASE-451 which isn't on the 0.90 branch.


Summary
-------

Backport to 0.90

commit 89862b73c6358e27220b87b0362599d86ab0fe4a
Author: Jonathan Hsieh <jon@cloudera.com>
Date:   Wed Sep 28 10:18:11 2011 -0700

    HBASE-4377 [hbck] Offline rebuild .META. from fs data only
    


This addresses bug HBASE-4377.
    https://issues.apache.org/jira/browse/HBASE-4377


Diffs (updated)
-----

  src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java ef246c3 
  src/main/java/org/apache/hadoop/hbase/util/Bytes.java 13ad026 
  src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java e0bd77e 
  src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java a981f72 
  src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java bd3b2f3 
  src/test/java/org/apache/hadoop/hbase/util/hbck/HbckTestingUtil.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java PRE-CREATION

  src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java PRE-CREATION

  src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java PRE-CREATION

  src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java PRE-CREATION


Diff: https://reviews.apache.org/r/2287/diff


Testing
-------

Note, the assertion test result is different in the failure cases due to HBASE-451 changes.
(0.90 returns 0 tables since it does a meta scan on empty meta, trunk branch looks at hdfs
dirs, and returns 1).

This version passes after HBASE-4508 (backport HBASE-3777 to 0.90 branch) is applied. 

I believe if that patch is not applied, I could modify the test code to force some explicit
HConnection deletions.


Thanks,

jmhsieh


                
> [hbck] Offline rebuild .META. from fs data only.
> ------------------------------------------------
>
>                 Key: HBASE-4377
>                 URL: https://issues.apache.org/jira/browse/HBASE-4377
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 0.92.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 0001-HBASE-4377-hbck-Offline-rebuild-.META.-from-fs-data-.0.90-v4.patch,
0001-HBASE-4377-hbck-Offline-rebuild-.META.-from-fs-data-.0.90.v3.patch, 0001-HBASE-4377-hbck-Offline-rebuild-.META.-from-fs-data-.patch,
0001-HBASE-4377-hbck-Offline-rebuild-.META.-from-fs-data-.trunk.v3.patch, 0001-HBASE-4377-hbck-Offline-rebuild-.META.-from-fs-data.0.92.v1.patch,
0001-HBASE-4377-hbck-Offline-rebuild-.META.-from-fs-data.0.92.v2.patch, EXT_AC.regioninfo,
EXT_ATU_05f84d32cbc0bdabf00e00bc2f3570f0.regioninfo, hbase-4377-trunk.v2.patch, hbase-4377.0.90.v6.patch,
hbase-4377.trunk.v3.txt, hbase-4377.trunk.v4.txt, hbase-4377.trunk.v5.txt, hbase-4377.trunk.v6.patch
>
>
> In a worst case situation, it may be helpful to have an offline .META. rebuilder that
just looks at the file system's .regioninfos and rebuilds meta from scratch.  Users could
move bad regions out until there is a clean rebuild.  
> It would likely fill in region split holes.  Follow on work could given options to merge
or select regions that overlap, or do online rebuilds.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message