hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mbautin (Mikhail Bautin)" <phabrica...@reviews.facebook.net>
Subject [Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.
Date Sat, 29 Oct 2011 00:44:41 GMT
mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print
all the key values for a specific row.".

  A few comments inline:

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:137 What happens
otherwise? I think we need to display an error message and terminate if the parameter is not
specified.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:239 Is row just the
row or the key portion of the KV, as the call suggests? If the latter, it is not clear to
me how we get an exact match on the row.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:256-257 If we did
not do a seekTo, this would produce a message for every row scanned before the row of interest.
Does it make sense to move the message out of the loop?

REVISION DETAIL
  https://reviews.facebook.net/D111

Mime
View raw message