hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4589) CacheOnWrite broken in some cases because it can conflict with evictOnClose
Date Fri, 14 Oct 2011 07:02:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127317#comment-13127317

stack commented on HBASE-4589:

Ignore my earlier mail.  You are on  this already.

+1 on patch.  Adding flag to the close is ugly but you keep the default of no arg so that
should work.
> CacheOnWrite broken in some cases because it can conflict with evictOnClose
> ---------------------------------------------------------------------------
>                 Key: HBASE-4589
>                 URL: https://issues.apache.org/jira/browse/HBASE-4589
>             Project: HBase
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.92.0
>         Attachments: HBASE-4589-v1.patch
> Commit of HBASE-4078 added some extra StoreFile verification which just did an open of
a StoreFile reader and then closes it, ensuring there's no exception.  If evict-on-close is
on, which it is by default, this causes all blocks of a file to be evicted even though it's
still open.
> We need to add the boolean into the close call in the way we have booleans for cacheBlocks
at some point since we need to make localized decisions in some cases.
> In lots of places, we can always rely on cacheConf.shouldEvictOnClose() so shouldn't
be too burdensome.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message