hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4070) [Coprocessors] Improve region server metrics to report loaded coprocessors to master
Date Wed, 05 Oct 2011 21:40:31 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121507#comment-13121507
] 

jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/
-----------------------------------------------------------

(Updated 2011-10-05 21:40:25.842211)


Review request for hbase and Mingjie Lai.


Changes
-------

Addressed Michael Stack's review (thanks St^Ack).

-in HServerLoad, clarify purpose of data member "coprocessors" versus "getCoprocessors()"
method.
-remove unneeded String Comparator.
-moved tests to TestClassLoading.java (thanks to Mingjie Lai for the suggestion)


Summary
-------

Proposed fix for HBASE-4070. 


This addresses bug HBASE-4070.
    https://issues.apache.org/jira/browse/HBASE-4070


Diffs (updated)
-----

  src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850 
  src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb 
  src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd 
  src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4 
  src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1 
  src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279 
  src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java eda5a9b 

Diff: https://reviews.apache.org/r/2029/diff


Testing
-------

Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported()
included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.


Thanks,

Eugene


                
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-4070
>                 URL: https://issues.apache.org/jira/browse/HBASE-4070
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.3
>            Reporter: Mingjie Lai
>            Assignee: Eugene Koontz
>         Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg,
rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need
a way to report this piece of information from region to master (or just at region server
level). So later on, we can display the loaded class names at shell as well as web console.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message