hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4649) Add atomic bulk load function to region server
Date Mon, 31 Oct 2011 18:09:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140388#comment-13140388
] 

ramkrishna.s.vasudevan commented on HBASE-4649:
-----------------------------------------------

{code}
      // were gathered and before the HReiogn's write lock was taken.  We need
{code}
Typo error - it should be HRegion
{code}
+        Store store = getStore(familyName);
+        if (store == null) {
+          IOException ioe = new DoNotRetryIOException(
+              "No such column family " + Bytes.toStringBinary(familyName));
+          ioes.add(ioe);
+          failures.add(p);
+        }
+
+        try {
+          store.assertBulkLoadHFileOk(new Path(path));
+        } catch (IOException ioe) {
{code}

What if store is null..invoking assertBulkLoadHFileOk() may cause exception right ?
                
> Add atomic bulk load function to region server
> ----------------------------------------------
>
>                 Key: HBASE-4649
>                 URL: https://issues.apache.org/jira/browse/HBASE-4649
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 0001-HBASE-4649-Add-atomic-bulk-load-function-to-region-s.patch,
hbase-4649.v2.patch, hbase-4649.v3.patch
>
>
> Add a method that atomically bulk load multiple hfiles.  Row atomicity guarantees for
multi-column family rows require this functionality.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message