hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4508) Backport HBASE-3777 to 0.90 branch
Date Thu, 20 Oct 2011 18:04:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131849#comment-13131849
] 

jiraposter@reviews.apache.org commented on HBASE-4508:
------------------------------------------------------



bq.  On 2011-10-20 17:31:06, Michael Stack wrote:
bq.  > Patch looks good to me.  Good stuff.  Before we commit, has anyone tested it doesn't
break compatibility?  It looks safe but its a big change so I think it needs testing.  I'll
do it if no one else has.

TestHCM.testManyNewConnectionsDoesnotOOME did OOME once we introduced hbase.connection.per.config
(default true) and before we set it false in that test.


- Bright


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2448/#review2705
-----------------------------------------------------------


On 2011-10-20 10:47:54, Bright Fulton wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2448/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-20 10:47:54)
bq.  
bq.  
bq.  Review request for hbase, Ted Yu and Bright Fulton.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  A backport of HBASE-3777 to the 0.90 branch, preserving 0.90 connection-per-config behavior
by introducing the (default true) hbase.connection.per.config config property.
bq.  
bq.  
bq.  This addresses bug HBASE-4508.
bq.      https://issues.apache.org/jira/browse/HBASE-4508
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/HConstants.java 611b149 
bq.    src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 64cabdf 
bq.    src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java aabf136 
bq.    src/main/java/org/apache/hadoop/hbase/client/HConnection.java ed2f554 
bq.    src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java e6d1583 
bq.    src/main/java/org/apache/hadoop/hbase/client/HTable.java cd5f167 
bq.    src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 78cb3d9 
bq.    src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java cfd86c9 
bq.    src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java d76e333

bq.    src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java 80284bb 
bq.    src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java 686813e 
bq.    src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
ed88bfa 
bq.    src/main/java/org/apache/hadoop/hbase/master/HMaster.java 88a5c20 
bq.    src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 923f891 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 72ba8dc 
bq.    src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
133da33 
bq.    src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
85cbb9e 
bq.    src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java b04aab6 
bq.    src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 06ac90b 
bq.    src/main/java/org/apache/hadoop/hbase/util/HMerge.java d727aa5 
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ec9f029 
bq.    src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java f277e6a 
bq.    src/main/resources/hbase-default.xml de2e91f 
bq.    src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java 910d68f 
bq.    src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditor.java 60320a3 
bq.    src/test/java/org/apache/hadoop/hbase/client/TestHCM.java 5d71d75 
bq.    src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java 624f4a8 
bq.    src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java 915cdf6 
bq.    src/test/java/org/apache/hadoop/hbase/util/TestMergeTable.java 8992dbb 
bq.  
bq.  Diff: https://reviews.apache.org/r/2448/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  All tests pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Bright
bq.  
bq.


                
> Backport HBASE-3777 to 0.90 branch
> ----------------------------------
>
>                 Key: HBASE-4508
>                 URL: https://issues.apache.org/jira/browse/HBASE-4508
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Bright Fulton
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4508.v1.patch, HBASE-4508.v2.patch, HBASE-4508.v3.patch, HBASE-4508.v4.patch
>
>
> See discussion here: http://search-hadoop.com/m/MJBId1aazTR1/backporting+HBASE-3777+to+0.90&subj=backporting+HBASE+3777+to+0+90
> Rocketfuel has been running 0.90.3 with HBASE-3777 since its resolution.
> They have 10 RS nodes , 1 Master and 1 Zookeeper
> Live writes and reads but super heavy on reads. Cache hit is pretty high.
> The qps on one of their data centers is 50K.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message