hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4686) [89-fb] Fix per-store metrics aggregation
Date Mon, 31 Oct 2011 23:13:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140663#comment-13140663
] 

Phabricator commented on HBASE-4686:
------------------------------------

Liyin has requested changes to the revision "[jira] [HBASE-4686] [89-fb] Fix per-store metrics
aggregation
".

  Thanks Mikhail for the patch.
  There are some comments inline.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:386 [code
style] Please add an empty line here
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:554 Why not
move this comments to line 551 ?
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:704 [code
style] please remove this empty line here
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1148 [code style] Please
write the standard java doc format
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1157 [code style] Please
remove the empty line here
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1219 [code style] Please
add an empty line here
  src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java:90 [code
style] Please remove the empty line here
  src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java:119 [code
style] Please remove the empty line here

REVISION DETAIL
  https://reviews.facebook.net/D87

                
> [89-fb] Fix per-store metrics aggregation 
> ------------------------------------------
>
>                 Key: HBASE-4686
>                 URL: https://issues.apache.org/jira/browse/HBASE-4686
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: D87.1.patch, D87.2.patch, D87.3.patch, HBASE-4686-TestRegionServerMetics-and-Store-metric-a-20111027134023-cc718144.patch,
HBASE-4686-jira-89-fb-Fix-per-store-metrics-aggregat-20111027152723-05bea421.patch
>
>
> In r1182034 per-Store metrics were broken, because the aggregation of StoreFile metrics
over all stores in a region was replaced by overriding them every time. We saw these metrics
drop by a factor of numRegions on a production cluster -- thanks to Kannan for noticing this!
 We need to fix the metrics and add a unit test to ensure regressions like this don't happen
in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message