hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print all the key values for a specific row.
Date Mon, 31 Oct 2011 17:45:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140369#comment-13140369
] 

Phabricator commented on HBASE-4698:
------------------------------------

mbautin has accepted the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print
all the key values for a specific row.".

  Looks good (a few very minor comments inline).

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71 Nit: it would
be nice to use Javadoc-style comments when referring to a specific field.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:133 Coding style:
space between key and !=
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:136-137 Nit: "the
kv" seems to imply there is only one kv for the row, which is most often not the case

REVISION DETAIL
  https://reviews.facebook.net/D111

                
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
>                 Key: HBASE-4698
>                 URL: https://issues.apache.org/jira/browse/HBASE-4698
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch
>
>
> When using HFile Pretty Printer to debug HBase issues, 
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print
all the key values for this row.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message