hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4460) Support running an embedded ThriftServer within a RegionServer
Date Thu, 20 Oct 2011 00:38:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131226#comment-13131226
] 

jiraposter@reviews.apache.org commented on HBASE-4460:
------------------------------------------------------



bq.  On 2011-10-20 00:34:31, Karthik Ranganathan wrote:
bq.  > Looks good to me, one minor nit... +1

Thanks for reviews guys.  I'm going to file a follow-up JIRA to deal with your comments (cleanup
and optimize).


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2410/#review2689
-----------------------------------------------------------


On 2011-10-17 22:37:43, Jonathan Gray wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2410/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-17 22:37:43)
bq.  
bq.  
bq.  Review request for hbase, Dhruba Borthakur, Gary Helmling, Michael Stack, and Andrew
Purtell.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Rather than a separate process, it can be advantageous in some situations for each RegionServer
to embed their own ThriftServer. This allows each embedded ThriftServer to short-circuit any
queries that should be executed on the local RS and skip the extra hop. This then enables
the building of fat Thrift clients that cache region locations and avoid extra hops all together.
bq.  
bq.  
bq.  This addresses bug HBASE-4460.
bq.      https://issues.apache.org/jira/browse/HBASE-4460
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java 1174376 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1174376 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java PRE-CREATION

bq.  
bq.  Diff: https://reviews.apache.org/r/2410/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Running this already on our hbase-92-based branch and running test site.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jonathan
bq.  
bq.


                
> Support running an embedded ThriftServer within a RegionServer
> --------------------------------------------------------------
>
>                 Key: HBASE-4460
>                 URL: https://issues.apache.org/jira/browse/HBASE-4460
>             Project: HBase
>          Issue Type: New Feature
>          Components: regionserver, thrift
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>         Attachments: HBASE-4460-v1.patch
>
>
> Rather than a separate process, it can be advantageous in some situations for each RegionServer
to embed their own ThriftServer.  This allows each embedded ThriftServer to short-circuit
any queries that should be executed on the local RS and skip the extra hop.  This then enables
the building of fat Thrift clients that cache region locations and avoid extra hops all together.
> This JIRA is just about the embedded ThriftServer.  Will open others for the rest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message