hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4689) [89-fb] Make the table level metrics work with rpc* metrics
Date Thu, 27 Oct 2011 23:38:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137749#comment-13137749
] 

jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/#review2899
-----------------------------------------------------------



src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6479>

    Mikhail, I have already used the constant for the prefix:)
    The cf name below is "real" column family name.



src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6480>

    The constant has been used in line #236:)
    Here is just the real cf name, not metric's prefix :)


- Liyin


On 2011-10-27 23:26:27, Liyin Tang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2587/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-27 23:26:27)
bq.  
bq.  
bq.  Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand
Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level
metrics even though we enabled the per table level metrics.
bq.  Fix this bug here.
bq.  
bq.  
bq.  This addresses bug HBASE-4689.
bq.      https://issues.apache.org/jira/browse/HBASE-4689
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe

bq.    src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a

bq.  
bq.  Diff: https://reviews.apache.org/r/2587/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Passed all the unit tests and tested the rpc metrics in the dev cluster
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Liyin
bq.  
bq.


                
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
>                 Key: HBASE-4689
>                 URL: https://issues.apache.org/jira/browse/HBASE-4689
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.89.20100924
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level
metrics even though we enabled the per table level metrics.
> Fix this bug here.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message