hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4519) 25s sleep when expiring sessions in tests
Date Sun, 30 Oct 2011 15:24:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139643#comment-13139643
] 

nkeywal commented on HBASE-4519:
--------------------------------

TestZooKeeper#testClientSessionExpired() has a very similar piece of code, with a 15s timeout
'only'. 
But when i tried this value, I had a failure in TestFromClientSide... to be continued
                
> 25s sleep when expiring sessions in tests
> -----------------------------------------
>
>                 Key: HBASE-4519
>                 URL: https://issues.apache.org/jira/browse/HBASE-4519
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>            Assignee: nkeywal
>             Fix For: 0.92.0
>
>
> There's a hardcoded 25 seconds sleep in HBaseTestingUtility.expireSession: 
> {code}
> int sessionTimeout = 5 * 1000; // 5 seconds
> ...
> final long sleep = sessionTimeout * 5L;
> LOG.info("ZK Closed Session 0x" + Long.toHexString(sessionID) +
>   "; sleeping=" + sleep);
> Thread.sleep(sleep);
> {code}
> I'm pretty sure this can be lowered at lot, and it would speed up a couple of tests.
The only thing I'm afraid of is if this was made to accomodate flaky tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message