hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)
Date Thu, 13 Oct 2011 20:07:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126873#comment-13126873
] 

Hudson commented on HBASE-4556:
-------------------------------

Integrated in HBase-0.92 #61 (See [https://builds.apache.org/job/HBase-0.92/61/])
    HBASE-4556 Fix all incorrect uses of InternalScanner.next(...)

larsh : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HMerge.java

                
> Fix all incorrect uses of InternalScanner.next(...)
> ---------------------------------------------------
>
>                 Key: HBASE-4556
>                 URL: https://issues.apache.org/jira/browse/HBASE-4556
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>         Attachments: 4556-v1.txt, 4556.txt
>
>
> There are cases all over the code where InternalScanner.next(...) is not used correctly.
> I see this a lot:
> {code}
> while(scanner.next(...)) {
> }
> {code}
> The correct pattern is:
> {code}
> boolean more = false;
> do {
>    more = scanner.next(...);
> } while (more);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message