hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4603) Uneeded sleep time for tests in hbase.master.ServerManager#waitForRegionServers
Date Sat, 29 Oct 2011 23:55:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139499#comment-13139499
] 

Hadoop QA commented on HBASE-4603:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501475/4603-v2.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated -166 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestDistributedLogSplitting

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/100//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/100//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/100//console

This message is automatically generated.
                
> Uneeded sleep time for tests in hbase.master.ServerManager#waitForRegionServers
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-4603
>                 URL: https://issues.apache.org/jira/browse/HBASE-4603
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.92.0
>         Environment: all.
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 20111017_4603_MiniHBaseCluster.patch, 4603-v2.txt
>
>
> This functions waits for at least 2 times hbase.master.wait.on.regionservers.interval,
defaulted at 3 seconds, i.e. 6 seconds for every mini hbase cluster starts.
> In the context of a mini cluster, it's not useful, as the regions servers are created
locally.
> Changing this to a lower value such as 100ms gives 5.8 second per HBase cluser start.
It should lower the build time on the apache server by more than 8%.
> Beeing more aggressive (removing all the wait time) could be possible as well. To be
studied later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message