hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4686) [89-fb] Fix per-store metrics aggregation
Date Thu, 27 Oct 2011 23:55:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137761#comment-13137761

Phabricator commented on HBASE-4686:

Liyin has accepted the revision "[jira] [HBASE-4686] [89-fb] Fix per-store metrics aggregation

  It looks good to me. Just one minor comments:

  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:384 This api
looks like very hard to use.
  Maybe we can elaborate what's in the map a little bit:)


> [89-fb] Fix per-store metrics aggregation 
> ------------------------------------------
>                 Key: HBASE-4686
>                 URL: https://issues.apache.org/jira/browse/HBASE-4686
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: D87.1.patch, HBASE-4686-TestRegionServerMetics-and-Store-metric-a-20111027134023-cc718144.patch,
> In r1182034 per-Store metrics were broken, because the aggregation of StoreFile metrics
over all stores in a region was replaced by overriding them every time. We saw these metrics
drop by a factor of numRegions on a production cluster -- thanks to Kannan for noticing this!
 We need to fix the metrics and add a unit test to ensure regressions like this don't happen
in the future.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message