hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4686) [89-fb] Fix per-store metrics aggregation
Date Thu, 27 Oct 2011 20:42:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137517#comment-13137517
] 

jiraposter@reviews.apache.org commented on HBASE-4686:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2590/
-----------------------------------------------------------

Review request for hbase and Liyin Tang.


Summary
-------

In r1182034 per-Store metrics were broken, because the aggregation of StoreFile metrics over
all stores in a region was replaced by overriding them every time. We saw these metrics drop
by a factor of numRegions on a production cluster – thanks to Kannan for noticing this!
We need to fix the metrics and add a unit test to ensure regressions like this don't happen
in the future.


This addresses bug HBASE-4686.
    https://issues.apache.org/jira/browse/HBASE-4686


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4a4436f 
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe 
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 7fd8977 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java PRE-CREATION

  src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a


Diff: https://reviews.apache.org/r/2590/diff


Testing
-------

Still running unit tests.


Thanks,

Mikhail


                
> [89-fb] Fix per-store metrics aggregation 
> ------------------------------------------
>
>                 Key: HBASE-4686
>                 URL: https://issues.apache.org/jira/browse/HBASE-4686
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: HBASE-4686-TestRegionServerMetics-and-Store-metric-a-20111027134023-cc718144.patch
>
>
> In r1182034 per-Store metrics were broken, because the aggregation of StoreFile metrics
over all stores in a region was replaced by overriding them every time. We saw these metrics
drop by a factor of numRegions on a production cluster -- thanks to Kannan for noticing this!
 We need to fix the metrics and add a unit test to ensure regressions like this don't happen
in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message