hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4377) [hbck] Offline rebuild .META. from fs data only.
Date Fri, 07 Oct 2011 21:02:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123197#comment-13123197
] 

jiraposter@reviews.apache.org commented on HBASE-4377:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2287/#review2440
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/2287/#comment5546>

    Minor suggestion: IOException may occur more than once. Would logging all such IOException's
before bailing out make user experience better ?
    Basically we just need to track the last such IOException in a variable and bail out at
line 283 if the variable isn't null.



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/2287/#comment5545>

    Naming rd as rootdir would make the code more readable.



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/2287/#comment5548>

    I think rebuildMeta() should check the return value from generatePuts().
    Otherwise we would encounter NPE at line 405 below.



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/2287/#comment5549>

    Do you plan to add this logic in another JIRA ?



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/2287/#comment5550>

    false should be returned if puts is null.



src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/2287/#comment5552>

    I think LOG.info() should be used here.


- Ted


On 2011-10-07 19:04:44, jmhsieh wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2287/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-07 19:04:44)
bq.  
bq.  
bq.  Review request for hbase and Ted Yu.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Backport to 0.90
bq.  
bq.  commit 89862b73c6358e27220b87b0362599d86ab0fe4a
bq.  Author: Jonathan Hsieh <jon@cloudera.com>
bq.  Date:   Wed Sep 28 10:18:11 2011 -0700
bq.  
bq.      HBASE-4377 [hbck] Offline rebuild .META. from fs data only
bq.      
bq.  
bq.  
bq.  This addresses bug HBASE-4377.
bq.      https://issues.apache.org/jira/browse/HBASE-4377
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java ef246c3 
bq.    src/main/java/org/apache/hadoop/hbase/util/Bytes.java 13ad026 
bq.    src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java b04aab6 
bq.    src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java PRE-CREATION

bq.    src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java f792720 
bq.    src/test/java/org/apache/hadoop/hbase/util/hbck/HbckTestingUtil.java PRE-CREATION 
bq.    src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java PRE-CREATION

bq.    src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java PRE-CREATION

bq.    src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java PRE-CREATION

bq.    src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/2287/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Note, the assertion test result is different in the failure cases due to HBASE-451 changes.
(0.90 returns 0 tables since it does a meta scan on empty meta, trunk branch looks at hdfs
dirs, and returns 1).
bq.  
bq.  This version passes after HBASE-4508 (backport HBASE-3777 to 0.90 branch) is applied.

bq.  
bq.  I believe if that patch is not applied, I could modify the test code to force some explicit
HConnection deletions.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  jmhsieh
bq.  
bq.


                
> [hbck] Offline rebuild .META. from fs data only.
> ------------------------------------------------
>
>                 Key: HBASE-4377
>                 URL: https://issues.apache.org/jira/browse/HBASE-4377
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 0001-HBASE-4377-hbck-Offline-rebuild-.META.-from-fs-data-.patch,
hbase-4377-trunk.v2.patch
>
>
> In a worst case situation, it may be helpful to have an offline .META. rebuilder that
just looks at the file system's .regioninfos and rebuilds meta from scratch.  Users could
move bad regions out until there is a clean rebuild.  
> It would likely fill in region split holes.  Follow on work could given options to merge
or select regions that overlap, or do online rebuilds.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message