hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4459) HbaseObjectWritable code is a byte, we will eventually run out of codes
Date Thu, 13 Oct 2011 19:43:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126854#comment-13126854
] 

Jonathan Gray commented on HBASE-4459:
--------------------------------------

- Why is Queue added within the scope of this JIRA?  Seems unrelated.

- Can you remove the unnecessary import re-org at the top?

- Can we have a unit test which shows the backwards compatibility of this?

Thanks for working on this Ram.
                
> HbaseObjectWritable code is a byte, we will eventually run out of codes
> -----------------------------------------------------------------------
>
>                 Key: HBASE-4459
>                 URL: https://issues.apache.org/jira/browse/HBASE-4459
>             Project: HBase
>          Issue Type: Bug
>          Components: io
>            Reporter: Jonathan Gray
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 0.92.0
>
>         Attachments: 4459.txt
>
>
> There are about 90 classes/codes in HbaseObjectWritable currently and Byte.MAX_VALUE
is 127.  In addition, anyone wanting to add custom classes but not break compatibility might
want to leave a gap before using codes and that's difficult in such limited space.
> Eventually we should get rid of this pattern that makes compatibility difficult (better
client/server protocol handshake) but we should probably at least bump this to a short for
0.94.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message