Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 16 Sep 2011 20:08:10 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <957384864.36237.1316203690484.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <720002909.12.1312232688751.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4153) Handle
 RegionAlreadyInTransitionException in AssignmentManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106770#comment-13106770 ] 

stack commented on HBASE-4153:
------------------------------

bq. Previously it was set.add() which was calling the map's entry set put if absent. So functionally there is no change. 

You are correct.  I thought it overwrote but looking at src, indeed its doing a putIfAbsent which is not what I'd expect but is in line with your assertion that functionally there is no change.

bq. If we are going to define this in one place then we need to find a common class and define it there.

There is HConstants for stuff that is common across the code base (though I don't like our overuse).  I'd think you'd put this where it feels most natural as a public static final -- into the exception class itself? -- and then have the other client reference it out of its home location.  What happens if this define gets changed in one place but not in the other.  Your check will break.

> Handle RegionAlreadyInTransitionException in AssignmentManager
> --------------------------------------------------------------
>
>                 Key: HBASE-4153
>                 URL: https://issues.apache.org/jira/browse/HBASE-4153
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.92.0
>
>         Attachments: 4153-v3.txt, HBASE-4153_1.patch, HBASE-4153_2.patch, HBASE-4153_3.patch
>
>
> Comment from Stack over in HBASE-3741:
> {quote}
> Question: Looking at this patch again, if we throw a RegionAlreadyInTransitionException, won't we just assign the region elsewhere though RegionAlreadyInTransitionException in at least one case here is saying that the region is already open on this regionserver?
> {quote}
> Indeed looking at the code it's going to be handled the same way other exceptions are. Need to add special cases for assign and unassign.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira