Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 28 Sep 2011 10:49:45 +0000 (UTC)
From: "Todd Lipcon (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <902928223.3235.1317206985429.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1215828429.3293.1316717246244.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4459) HbaseObjectWritable code is a byte,
 we will eventually run out of codes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116333#comment-13116333 ] 

Todd Lipcon commented on HBASE-4459:
------------------------------------

The scheme in WritableUtils.writeVInt looks like it's backwards-compatible for small positive bytes:
{code}
    if (i >= -112 && i <= 127) {
      stream.writeByte((byte)i);
      return;
    }
{code}
                
> HbaseObjectWritable code is a byte, we will eventually run out of codes
> -----------------------------------------------------------------------
>
>                 Key: HBASE-4459
>                 URL: https://issues.apache.org/jira/browse/HBASE-4459
>             Project: HBase
>          Issue Type: Bug
>          Components: io
>            Reporter: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.94.0
>
>
> There are about 90 classes/codes in HbaseObjectWritable currently and Byte.MAX_VALUE is 127.  In addition, anyone wanting to add custom classes but not break compatibility might want to leave a gap before using codes and that's difficult in such limited space.
> Eventually we should get rid of this pattern that makes compatibility difficult (better client/server protocol handshake) but we should probably at least bump this to a short for 0.94.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira