Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C90347BA2 for ; Thu, 22 Sep 2011 17:37:47 +0000 (UTC) Received: (qmail 87962 invoked by uid 500); 22 Sep 2011 17:37:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 87942 invoked by uid 500); 22 Sep 2011 17:37:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 87930 invoked by uid 99); 22 Sep 2011 17:37:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2011 17:37:47 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2011 17:37:46 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 3269EA93A0 for ; Thu, 22 Sep 2011 17:37:26 +0000 (UTC) Date: Thu, 22 Sep 2011 17:37:26 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: <893000863.2956.1316713046203.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <197853141.26748.1315418949853.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4344) Persist memstoreTS to disk MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112736#comment-13112736 ] Lars Hofhansl commented on HBASE-4344: -------------------------------------- Hmm... See this code in SplitTransaction.java: {code} case CLOSED_PARENT_REGION: // So, this returns a seqid but if we just closed and then reopened, we // should be ok. On close, we flushed using sequenceid obtained from // hosting regionserver so no need to propagate the sequenceid returned // out of initialize below up into regionserver as we normally do. // TODO: Verify. this.parent.initialize(); break; {code} This is where it fails. Moving initialization of rwcc to HRegion.initialize rather then at construction time fixes this for me. > Persist memstoreTS to disk > -------------------------- > > Key: HBASE-4344 > URL: https://issues.apache.org/jira/browse/HBASE-4344 > Project: HBase > Issue Type: Sub-task > Reporter: Amitanand Aiyer > Assignee: Amitanand Aiyer > Fix For: 0.89.20100924 > > Attachments: 4344-v2.txt, 4344-v4.txt, 4344-v5.txt, 4344-v6.txt, patch-2 > > > Atomicity can be achieved in two ways -- (i) by using a multiversion concurrency system (MVCC), or (ii) by ensuring that "new" writes do not complete, until the "old" reads complete. > Currently, Memstore uses something along the lines of MVCC (called RWCC for read-write-consistency-control). But, this mechanism is not incorporated for the key-values written to the disk, as they do not include the memstore TS. > Let us make the two approaches be similar, by persisting the memstoreTS along with the key-value when it is written to the disk. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira