Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 14 Sep 2011 00:26:09 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <840666206.24664.1315959969384.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <314083017.10282.1315608488823.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4363) [replication] ReplicationSource
 won't close if failing to contact the sink
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104101#comment-13104101 ] 

stack commented on HBASE-4363:
------------------------------

isReplicating a better name for the isActive method? (The latter is generic)

What is this.running?  Whats it signify?

Otherwise patch seems fine.


> [replication] ReplicationSource won't close if failing to contact the sink
> --------------------------------------------------------------------------
>
>                 Key: HBASE-4363
>                 URL: https://issues.apache.org/jira/browse/HBASE-4363
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4363-0.90.patch
>
>
> When trying to close a source, it will hang if it's already in shipEdits() and has issues reaching the sink. The reason is that in that method the while loop only checks if the RS is going down but not if the source was asked to shutdown.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira