Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 16 Sep 2011 16:12:11 +0000 (UTC)
From: "jiraposter@reviews.apache.org (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <48212839.35190.1316189531689.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1315401189.7638.1314899710021.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4322) [hbck] Update
 checkIntegrity/checkRegionChain to present more accurate region split
 problem summary
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106563#comment-13106563 ] 

jiraposter@reviews.apache.org commented on HBASE-4322:
------------------------------------------------------


bq.  On 2011-09-15 04:02:22, Michael Stack wrote:
bq.  > You want me to commit this Jon?  It looks like its prereq went in already.
bq.  
bq.  jmhsieh wrote:
bq.      Can we commit after I fix the final nit you noted? 
bq.      
bq.      For the backwards regions counting, can I just file another JIRA to deal with backwards regions?  I think backwards regions should be really extremely rare.
bq.  
bq.  Michael Stack wrote:
bq.      Let me do the nit on commit.
bq.  
bq.  Michael Stack wrote:
bq.      And, sure to making new issue for count of backward regions.

Just looked at the backwards thing and it could actually easily be fixed with this:

   public int getNumRegions() {
      return sc.getStarts().size() + backwards.size();
    }


- jmhsieh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1789/#review1906
-----------------------------------------------------------


On 2011-09-14 16:02:13, jmhsieh wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1789/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-14 16:02:13)
bq.  
bq.  
bq.  Review request for hbase, Todd Lipcon and Michael Stack.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This requires HBASE-4321.
bq.  
bq.  commit 0ed6be1b628f3c030480164af37825702a2d5020
bq.  Author: Jonathan Hsieh <jon@cloudera.com>
bq.  Date:   Mon Sep 5 02:16:32 2011 -0700
bq.  
bq.      HBASE-4322 [hbck] Update checkIntegrity/checkRegionChain to present more accurate region split problem summary
bq.      
bq.      Minor semantics change
bq.      - if two regions overlap this counts as two inconsistencies instead of one. If three overlap, it counts as three.
bq.      - testMetaHole was previously actually was an overlap ([D,E] overlaps [C,]).  Change to make true hole.
bq.  
bq.  
bq.  This addresses bug HBASE-4322.
bq.      https://issues.apache.org/jira/browse/HBASE-4322
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java a152bcb 
bq.    src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java f42a87c 
bq.    src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckComparator.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1789/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Modified unit test passes.  Currently running full suite.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  jmhsieh
bq.  
bq.


> [hbck] Update checkIntegrity/checkRegionChain to present more accurate region split problem summary
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4322
>                 URL: https://issues.apache.org/jira/browse/HBASE-4322
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>    Affects Versions: 0.90.4, 0.94.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 0001-HBASE-4322-hbck-Update-checkIntegrity-checkRegionCha.patch, 0001-HBASE-4322-hbck-Update-checkIntegrity-checkRegionCha.patch, 0001-HBASE-4322-hbck-Update-checkIntegrity-checkRegionCha.v3.0.90.patch, 0001-HBASE-4322-hbck-Update-checkIntegrity-checkRegionCha.v3.patch, hbase-4322-0.90.patch
>
>
> This is a mostly semantics preserving upgrade to hbck that uses the RegionSplitCalculator from HBASE-4321 that provides more in depth information about region split problems in meta when running hbck.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira