Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 23 Sep 2011 03:35:26 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <267298237.4912.1316748926138.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1215828429.3293.1316717246244.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4459) HbaseObjectWritable code is a byte,
 we will eventually run out of codes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113136#comment-13113136 ] 

Ted Yu commented on HBASE-4459:
-------------------------------

+1 on making code of type short.

> HbaseObjectWritable code is a byte, we will eventually run out of codes
> -----------------------------------------------------------------------
>
>                 Key: HBASE-4459
>                 URL: https://issues.apache.org/jira/browse/HBASE-4459
>             Project: HBase
>          Issue Type: Bug
>          Components: io
>            Reporter: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.94.0
>
>
> There are about 90 classes/codes in HbaseObjectWritable currently and Byte.MAX_VALUE is 127.  In addition, anyone wanting to add custom classes but not break compatibility might want to leave a gap before using codes and that's difficult in such limited space.
> Eventually we should get rid of this pattern that makes compatibility difficult (better client/server protocol handshake) but we should probably at least bump this to a short for 0.94.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira