Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 17 Sep 2011 01:01:27 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1639068071.37552.1316221287374.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1678904075.35862.1316198469008.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4420) MasterObserver preMove() and
 postMove() should throw IOException instead of UnknownRegionException
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106976#comment-13106976 ] 

Hudson commented on HBASE-4420:
-------------------------------

Integrated in HBase-TRUNK #2223 (See [https://builds.apache.org/job/HBase-TRUNK/2223/])
    HBASE-4420  MasterObserver preMove() and postMove() should throw IOException

garyh : 
Files : 
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java


> MasterObserver preMove() and postMove() should throw IOException instead of UnknownRegionException
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4420
>                 URL: https://issues.apache.org/jira/browse/HBASE-4420
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4420.patch
>
>
> We've standardized on IOException as the main way for coprocessors to communicate errors back out of the Observer hooks.  All Observer hooks throw IOE except for MasterObserver.preMove() and MasterObserver.postMove(), which throw UnknownRegionException, since that's what HMasterInterface.move() declares.  In hindsight, making these two MasterObserver methods inconsistent seems like a mistake.
> I think we should change MasterObserver.preMove() and MasterObserver.postMove() to throw IOException for consistency with the other methods.  We could deprecate the existing HMasterInterface.move() method to have it switch over to throwing IOException as well, but this would require creating a version with a new name, which seems unnecessarily ugly.  So I'd suggest we just have HMaster.move() handle the IOException and use it to init an UnknownRegionException.  Wonky as that is, it seems the lesser evil.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira