Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 16 Sep 2011 06:39:08 +0000 (UTC)
From: "Gary Helmling (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1625695351.33826.1316155148869.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <161026579.17068.1315833549148.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4373) HBaseAdmin.assign() doesnot use
 force flag
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105904#comment-13105904 ] 

Gary Helmling commented on HBASE-4373:
--------------------------------------

Ram,

For MasterObserver, BaseMasterObserver, TestMasterObserver, I'd say there's no need to deprecate the existing verison of the methods.  Coprocessors have not been released yet, so those classes don't represent an API we have to maintain yet.  You can just remove the flag.

Otherwise the patch looks good to me.

> HBaseAdmin.assign() doesnot use force flag
> ------------------------------------------
>
>                 Key: HBASE-4373
>                 URL: https://issues.apache.org/jira/browse/HBASE-4373
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>         Attachments: HBASE-4373.patch, HBASE-4373_1.patch
>
>
> The HBaseAdmin.assign()
> {code}
>   public void assign(final byte [] regionName, final boolean force)
>   throws MasterNotRunningException, ZooKeeperConnectionException, IOException {
>     getMaster().assign(regionName, force);
>   }
> {code}
> In the HMaster we call 
> {code}
>     Pair<HRegionInfo, ServerName> pair =
>       MetaReader.getRegion(this.catalogTracker, regionName);
>     if (pair == null) throw new UnknownRegionException(Bytes.toString(regionName));
>     if (cpHost != null) {
>       if (cpHost.preAssign(pair.getFirst(), force)) {
>         return;
>       }
>     }
>     assignRegion(pair.getFirst());
>     if (cpHost != null) {
>       cpHost.postAssign(pair.getFirst(), force);
>     }
> {code}
> The force flag is not getting used.  May be we need to update the javadoc or do not provide the force flag as a parameter if we are not going to use it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira