Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 14 Sep 2011 01:32:09 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1119102867.24941.1315963929435.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1619027623.23955.1315947549219.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4390) [replication] ReplicationSource's
 UncaughtExceptionHandler shouldn't join
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104150#comment-13104150 ] 

stack commented on HBASE-4390:
------------------------------

+1

You install this exception catcher because you don't want 'anything' to kill the thread?


> [replication] ReplicationSource's UncaughtExceptionHandler shouldn't join
> -------------------------------------------------------------------------
>
>                 Key: HBASE-4390
>                 URL: https://issues.apache.org/jira/browse/HBASE-4390
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4390-0.90.patch
>
>
> From Jeff Whiting on the ML:
> {quote}
> "regionserver60020.replicationSource,dev2" daemon prio=10 tid=0x00002aaaf0312800 nid=0x69f8 in Object.wait() [0x000000004533e000]
>   java.lang.Thread.State: TIMED_WAITING (on object monitor)
>    at java.lang.Object.wait(Native Method)
>    - waiting on <0x00002aaab12464c0> (a org.apache.hadoop.hbase.replication.regionserver.ReplicationSource)
>    at java.lang.Thread.join(Thread.java:1151)
>    - locked <0x00002aaab12464c0> (a org.apache.hadoop.hbase.replication.regionserver.ReplicationSource)
>    at org.apache.hadoop.hbase.util.Threads.shutdown(Threads.java:91)
>    at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.terminate(ReplicationSource.java:649)
>    at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$1.uncaughtException(ReplicationSource.java:628)
>    at java.lang.Thread.dispatchUncaughtException(Thread.java:1831)
> {quote}
> That's pretty dumb, the thread is trying to join itself. UncaughtExceptionHandler shouldn't try to terminate() but just clear resources and then return.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira