hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make adding individual hbck tests easier
Date Mon, 05 Sep 2011 18:40:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097233#comment-13097233
] 

jiraposter@reviews.apache.org commented on HBASE-4313:
------------------------------------------------------



bq.  On 2011-09-05 17:53:41, Todd Lipcon wrote:
bq.  > src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java, line 191
bq.  > <https://reviews.apache.org/r/1713/diff/1/?file=37949#file37949line191>
bq.  >
bq.  >     maybe name the tables after the tests?

done: tableDupStartKey, tableClean, tableOverlapStartKey, tableMetaHole


bq.  On 2011-09-05 17:53:41, Todd Lipcon wrote:
bq.  > src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java, line 204
bq.  > <https://reviews.apache.org/r/1713/diff/1/?file=37949#file37949line204>
bq.  >
bq.  >     what's this comment mean?

removed.  This was broken when debugging the refactor.


bq.  On 2011-09-05 17:53:41, Todd Lipcon wrote:
bq.  > src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java, line 216
bq.  > <https://reviews.apache.org/r/1713/diff/1/?file=37949#file37949line216>
bq.  >
bq.  >     name this something like "NoErrors"? The test is that a clean table checks out
OK

testHBaseFsckClean


bq.  On 2011-09-05 17:53:41, Todd Lipcon wrote:
bq.  > src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java, line 212
bq.  > <https://reviews.apache.org/r/1713/diff/1/?file=37949#file37949line212>
bq.  >
bq.  >     usually we put @Test after the javadoc

done


- jmhsieh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1713/#review1746
-----------------------------------------------------------


On 2011-09-05 10:28:15, jmhsieh wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1713/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-05 10:28:15)
bq.  
bq.  
bq.  Review request for hbase, Todd Lipcon and Michael Stack.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is a mostly semantics preserving patch.  This will make HBASE-3354 easier to do.
 Trunk based version of patch to follow.
bq.  
bq.  commit 6712c70b524bedf6a5e4999d4d2203373b0f1772
bq.  Author: Jonathan Hsieh <jon@cloudera.com>
bq.  Date:   Thu Aug 25 00:10:27 2011 -0700
bq.  
bq.      HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
bq.      
bq.      - Cleanup table creation
bq.      - Add proper MiniCluster shutdown
bq.      - Separate each corruption into a separate test
bq.  
bq.  
bq.  This addresses bug HBASE-4313.
bq.      https://issues.apache.org/jira/browse/HBASE-4313
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 1c766b3 
bq.  
bq.  Diff: https://reviews.apache.org/r/1713/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  tests pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  jmhsieh
bq.  
bq.



> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
>                 Key: HBASE-4313
>                 URL: https://issues.apache.org/jira/browse/HBASE-4313
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table.
 This refactor essentially preserves what is tested but isolates each error type so that there
is no bleed over in error from table to table.  This will also enable the writing of other
simple to read tests for other hbck detectable errors.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message