hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Date Wed, 14 Sep 2011 22:46:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104959#comment-13104959
] 

Ted Yu commented on HBASE-4310:
-------------------------------

I only see two notifications from HUDSON on this ticket.
The commit @ 2011-09-02 07:31:29 fixed the condition in an assertion:
{code}
-      assert(test.getUpperBound(i) < test.getLowerBound(i + 1));
+      assertTrue("Upper for index " + i + " is " + test.getUpperBound(i) +
+          " lower " + test.getLowerBound(i + 1),
+          test.getUpperBound(i) <= test.getLowerBound(i + 1));
{code}
The addition of = came with the change in the way bounds are generated.
Without the above, TestSlabCache would fail.

I can remove the duplicate line in CHANGES.txt

> SlabCache metrics bugfix.
> -------------------------
>
>                 Key: HBASE-4310
>                 URL: https://issues.apache.org/jira/browse/HBASE-4310
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt,
metricsv3.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics
of size 0 to save space. Also added second log for those things that are successfully cached.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message