hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4344) Persist memstoreTS to disk
Date Wed, 21 Sep 2011 02:41:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109228#comment-13109228
] 

Ted Yu commented on HBASE-4344:
-------------------------------

Got a few test failures so far:
{code}
testHFileFormatV2(org.apache.hadoop.hbase.io.hfile.TestHFileWriterV2)  Time elapsed: 0.704
sec  <<< FAILURE!
java.lang.AssertionError: 
        at org.junit.Assert.fail(Assert.java:91)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at org.junit.Assert.assertTrue(Assert.java:54)
        at org.apache.hadoop.hbase.io.hfile.TestHFileWriterV2.testHFileFormatV2(TestHFileWriterV2.java:141)

testCacheOnWrite[5](org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite)  Time elapsed: 0.741
sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<{DATA=1[367, LEAF_INDEX=172, BLOOM_CHUNK=9, INTERMEDIATE_INDEX=24]}>
but was:<{DATA=1[459, LEAF_INDEX=183, BLOOM_CHUNK=9, INTERMEDIATE_INDEX=25]}>
        at org.junit.Assert.assertEquals(Assert.java:123)
        at org.junit.Assert.assertEquals(Assert.java:145)
        at org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.readStoreFile(TestCacheOnWrite.java:180)
        at org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testCacheOnWrite(TestCacheOnWrite.java:150)

testCacheOnWrite[0](org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite)  Time elapsed: 1.129
sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<{DATA=1[367, LEAF_INDEX=172, BLOOM_CHUNK=9, INTERMEDIATE_INDEX=24]}>
but was:<{DATA=1[459, LEAF_INDEX=183, BLOOM_CHUNK=9, INTERMEDIATE_INDEX=25]}>
        at org.junit.Assert.assertEquals(Assert.java:123)
        at org.junit.Assert.assertEquals(Assert.java:145)
        at org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.readStoreFile(TestCacheOnWrite.java:180)
        at org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testCacheOnWrite(TestCacheOnWrite.java:150)

testSeekBefore(org.apache.hadoop.hbase.io.hfile.TestSeekTo)  Time elapsed: 0.232 sec  <<<
ERROR!
java.lang.IllegalStateException: blockSeek with seekBefore at the first key of the block:
key=\x00\x01c\x06familyqualifier\x7F\xFF\xFF\xFF\xFF\xFF\xFF\xFF\x04, blockOffset=0, onDiskSize=171
        at org.apache.hadoop.hbase.io.hfile.HFileReaderV2$ScannerV2.blockSeek(HFileReaderV2.java:647)
        at org.apache.hadoop.hbase.io.hfile.HFileReaderV2$ScannerV2.loadBlockAndSeekToKey(HFileReaderV2.java:577)
        at org.apache.hadoop.hbase.io.hfile.HFileReaderV2$ScannerV2.seekBefore(HFileReaderV2.java:732)
        at org.apache.hadoop.hbase.io.hfile.HFileReaderV2$ScannerV2.seekBefore(HFileReaderV2.java:687)
        at org.apache.hadoop.hbase.io.hfile.TestSeekTo.testSeekBefore(TestSeekTo.java:70)
{code}

> Persist memstoreTS to disk
> --------------------------
>
>                 Key: HBASE-4344
>                 URL: https://issues.apache.org/jira/browse/HBASE-4344
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Amitanand Aiyer
>            Assignee: Amitanand Aiyer
>             Fix For: 0.89.20100924
>
>         Attachments: 4344-v2.txt, patch-2
>
>
> Atomicity can be achieved in two ways -- (i) by using  a multiversion concurrency system
(MVCC), or (ii) by ensuring that "new" writes do not complete, until the "old" reads complete.
> Currently, Memstore uses something along the lines of MVCC (called RWCC for read-write-consistency-control).
But, this mechanism is not incorporated for the key-values written to the disk, as they do
not include the memstore TS.
> Let us make the two approaches be similar, by persisting the memstoreTS along with the
key-value when it is written to the disk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message