hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4438) Speed the build test phase
Date Tue, 20 Sep 2011 02:16:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108331#comment-13108331
] 

Jesse Yates commented on HBASE-4438:
------------------------------------

(sorry, miss click - here are the rest of the details)

*Option 2*
We move refactor hbase into a top level pom w/ several sub-packages. This helps to break out
different concerns. It will also be good later if we want to break out core into a couple
different pieces. Right now this would just entail a slight change in structure:
{noformat}
hbase/
   /hbase-core
   /hbase-it
{noformat}

where hbase-it would have the integration tests, utils for the tests, and unit tests of those
utils. It would be a 'full' package. Again we stick to the above naming convention (or specify
our own) for integration tests

*Option 3*
Similar to the above, but we only make hbase-it a submodule of hbase (leave the structure
the same). This still remains a full featured package. The directory structure looks like
this:
{noformat}
hbase/
  /src/main/java
  ...
  /hbase-it
    /src/main/java
    ...
{noformat}

Right now, I can't figure out how to get the maven-failsafe-plugin to read from a directory
other than /src/test/java, but if I can figure it out, that would be best when combined with
Option 1 - keeps same structure, breaks out integration tests. 

Given that, I am more inclined to go with Option 2 or 3. These helps break out concerns into
different packages, rather than munging them all together. 

Working on a patch now for #3  - its the simplest to break out. #2 wouldn't be terrible, but
would require more delicacy. #1 is simple and is a matter of minutes, if we want to go that
route.


What does everyone think? 

> Speed the build test phase
> --------------------------
>
>                 Key: HBASE-4438
>                 URL: https://issues.apache.org/jira/browse/HBASE-4438
>             Project: HBase
>          Issue Type: Umbrella
>          Components: test
>            Reporter: stack
>
> We're up to 2hrs 15mins running tests on jenkins which is kinda crazy.  Akash started
a thread over in dev on fixing this: http://search-hadoop.com/m/cZjDH1ykGIA/Running+UnitTests+before+submitting+a+patch&subj=Running+UnitTests+before+submitting+a+patch
> Jessie brings up http://maven.apache.org/plugins/maven-failsafe-plugin/ which looks like
something we need to start using; having a tiering of our testing would make sense to me.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message