hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4373) HBaseAdmin.assign() does not use force flag
Date Fri, 16 Sep 2011 19:52:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106760#comment-13106760
] 

Jonathan Gray commented on HBASE-4373:
--------------------------------------

Trying to understand this patch.  So with the force flag removed, what is the default behavior?
 If the state is not OFFLINE and we try to assign somewhere else, do we force the node to
OFFLINE always?

> HBaseAdmin.assign() does not use force flag
> -------------------------------------------
>
>                 Key: HBASE-4373
>                 URL: https://issues.apache.org/jira/browse/HBASE-4373
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4373.patch, HBASE-4373_1.patch
>
>
> The HBaseAdmin.assign()
> {code}
>   public void assign(final byte [] regionName, final boolean force)
>   throws MasterNotRunningException, ZooKeeperConnectionException, IOException {
>     getMaster().assign(regionName, force);
>   }
> {code}
> In the HMaster we call 
> {code}
>     Pair<HRegionInfo, ServerName> pair =
>       MetaReader.getRegion(this.catalogTracker, regionName);
>     if (pair == null) throw new UnknownRegionException(Bytes.toString(regionName));
>     if (cpHost != null) {
>       if (cpHost.preAssign(pair.getFirst(), force)) {
>         return;
>       }
>     }
>     assignRegion(pair.getFirst());
>     if (cpHost != null) {
>       cpHost.postAssign(pair.getFirst(), force);
>     }
> {code}
> The force flag is not getting used.  May be we need to update the javadoc or do not provide
the force flag as a parameter if we are not going to use it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message