hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4270) IOE ignored during flush-on-close causes dataloss
Date Fri, 09 Sep 2011 23:08:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101630#comment-13101630
] 

jiraposter@reviews.apache.org commented on HBASE-4270:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1784/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Todd wrote the patch for this issue.  Whats posted here is his patch plus a unit test.  The
diff is pretty big because I refactored the TestOpenRegionHandler so I could share bits of
it creating this new TestCloseRegionHandler; the bulk of the patch is making shared mock server
and shared mock regionserverservice files.


This addresses bug hbase-4270.
    https://issues.apache.org/jira/browse/hbase-4270


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java b684af2

  src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockServer.java PRE-CREATION

  src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java PRE-CREATION

  src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java ab12968


Diff: https://reviews.apache.org/r/1784/diff


Testing
-------

I ran the new TestCloseRegionHandler test.


Thanks,

Michael



> IOE ignored during flush-on-close causes dataloss
> -------------------------------------------------
>
>                 Key: HBASE-4270
>                 URL: https://issues.apache.org/jira/browse/HBASE-4270
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.92.0
>
>         Attachments: 0001-HBASE-4270.-Abort-and-rethrow-errors-on-close-failur.patch
>
>
> If the RS experiences an exception during the flush of a region while closing it, it
currently catches the exception, logs a warning, and keeps going. If the exception was a DroppedSnapshotException,
this means that it will silently drop any data that was in memstore when the region was closed.
> Instead, the RS should do a hard abort so that its logs will be replayed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message