hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4488) Store could miss rows during flush
Date Tue, 27 Sep 2011 05:11:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115220#comment-13115220
] 

Lars Hofhansl commented on HBASE-4488:
--------------------------------------

Looking at the StoreScanner/ScanQueryMatcher code, it seems that luckily this cannot be triggered.
In order to this to happen the ScanQueryMatcher in StoreScanner has to return one of DONE_SCAN
or SEEK_NEXT_ROW.
The matcher only return DONE_SCAN for filters. In this case there are none, so that won't
happen.
SEEK_NEXT_ROW can be return from filters (so also out) or if the next row is < the current
row (not sure how to make that happen... Should never happen).
The column tracker used here is ScanWildcardColumnTracker, which will only ever return SKIP,
SEEK_NEXT_COL, or INCLUDE.

So we were actually lucky here, and this bug cannot be triggered at all. Based on this I'll
change the priority. Unless we rig it, this bug cannot be triggered.

It should still be changed, though, but it will be for readability, and future correctness
if somebody changes Matcher/Tracker.

                
> Store could miss rows during flush
> ----------------------------------
>
>                 Key: HBASE-4488
>                 URL: https://issues.apache.org/jira/browse/HBASE-4488
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>             Fix For: 0.92.0, 0.94.0
>
>         Attachments: 4488.txt
>
>
> While looking at HBASE-4344 I found that my change HBASE-4241 contains a critical mistake:
> The while(scanner.next(kvs)) loop is incorrect and might miss the last edits.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message