hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-4206) jenkins hash implementation uses longs unnecessarily
Date Sun, 04 Sep 2011 22:59:09 GMT

     [ https://issues.apache.org/jira/browse/HBASE-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-4206:
-------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Thank you for the nice patch Ron.  Applied TRUNK.

> jenkins hash implementation uses longs unnecessarily
> ----------------------------------------------------
>
>                 Key: HBASE-4206
>                 URL: https://issues.apache.org/jira/browse/HBASE-4206
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.90.4
>            Reporter: Ron Yang
>            Assignee: Ron Yang
>            Priority: Minor
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: JenkinsHashTest.tgz, ryang.patch
>
>
> I don't believe you need to use long for a,b,c and as a result no longer need to &
against INT_MASK.
> At a minimum the private static longs should be made final, and the "main" method should
not print the absolute value of the hash but instead use something like Integer.toHexString

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message