hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4384) Hard to tell what causes failure in CloseRegionHandler#getCurrentVersion
Date Tue, 13 Sep 2011 19:39:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103926#comment-13103926
] 

Harsh J commented on HBASE-4384:
--------------------------------

stack, No, patch is for all branches 0.90 to trunk. Please disregard my first comment, it
was made when I was under a great deal of workspace switching and I thought I was looking
at one snippet of trunk source, while I was looking at something else instead.

This patch is targeted for trunk, but can also be backported atop other branches (0.92 if
branched already, and 0.90).

> Hard to tell what causes failure in CloseRegionHandler#getCurrentVersion
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4384
>                 URL: https://issues.apache.org/jira/browse/HBASE-4384
>             Project: HBase
>          Issue Type: Task
>          Components: zookeeper
>    Affects Versions: 0.90.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4384.r1.diff
>
>
> The current code goes like:
> {code}
> 172    * Get the node's current version
> 173    * @return The expectedVersion.  If -1, we failed getting the node
> 174    */
> 175   private int getCurrentVersion() {
> 176     int expectedVersion = FAILED;
> 177     try {
> 178       if ((expectedVersion = ZKAssign.getVersion(
> 179           server.getZooKeeper(), regionInfo)) == FAILED) {
> 180         LOG.warn("Error getting node's version in CLOSING state," +
> 181           " aborting close of " + regionInfo.getRegionNameAsString());
> 182       }
> 183     } catch (KeeperException e) {
> 184       LOG.warn("Error creating node in CLOSING state, aborting close of " +
> 185         regionInfo.getRegionNameAsString());
> 186     }
> 187     return expectedVersion;
> 188   }
> 189 }
> {code}
> Both WARN cases would be identical this way. In case of an exception, I think an exception
ought to be logged as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message