hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4070) [Coprocessors] Improve region server metrics to report loaded coprocessors to master
Date Fri, 30 Sep 2011 17:31:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118220#comment-13118220
] 

jiraposter@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------



bq.  On 2011-09-29 21:52:40, Andrew Purtell wrote:
bq.  >
bq.  
bq.  Andrew Purtell wrote:
bq.      Actually, I do have a comment. Do we need a method in HMasterInterface for getting
the coprocessor set? Can't it be extracted from HSL?
bq.  
bq.  Andrew Purtell wrote:
bq.      I meant via ClusterStatus, therefore via HBaseAdmin.getClusterStatus().
bq.  
bq.  Eugene Koontz wrote:
bq.      Removed HMasterInterface change since we don't need it.
bq.      
bq.      ClusterStatus constructor has an additional param that is the string representation
of the Master's loaded coprocessor set.
bq.      
bq.      HBaseAdmin can now use getClusterStatus() to get Master's coprocessor set. HBASE-3512's
patch will be updated to use this to show master coprocessors in the shell.

Cool, thanks Eugene


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2179
-----------------------------------------------------------


On 2011-09-30 04:58:20, Eugene Koontz wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2029/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-30 04:58:20)
bq.  
bq.  
bq.  Review request for hbase and Mingjie Lai.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Proposed fix for HBASE-4070. 
bq.  
bq.  
bq.  This addresses bug HBASE-4070.
bq.      https://issues.apache.org/jira/browse/HBASE-4070
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon abeb850 
bq.    src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon be6fceb 
bq.    src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd 
bq.    src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4 
bq.    src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java dbae4fd 
bq.    src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java PRE-CREATION

bq.  
bq.  Diff: https://reviews.apache.org/r/2029/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Two new tests : testRegionServerCoprocessorReported() and testMasterServerCoprocessorsReported()
included in a new source file src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Eugene
bq.  
bq.


                
> [Coprocessors] Improve region server metrics to report loaded coprocessors to master
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-4070
>                 URL: https://issues.apache.org/jira/browse/HBASE-4070
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.3
>            Reporter: Mingjie Lai
>            Assignee: Eugene Koontz
>         Attachments: HBASE-4070.patch, HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more generic, we need
a way to report this piece of information from region to master (or just at region server
level). So later on, we can display the loaded class names at shell as well as web console.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message